Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change overwrite templates feature for action menu #1036

Conversation

SilinMykola
Copy link

Description (*)
Hello! I changed the behavior for the action menu for overwriting template files.
Now we have one menu and dialog window for templates and less files.
image
image
image
image
Now plugin copied correctly the files to the selected theme.
image
I also changed the gear of overwriting the layout files
image
image
image

Fixed Issues (if relevant)

  1. Fixes [Bug] ArrayIndexOutOfBoundsException in OverrideInThemeDialog.fillThemeOptions #1026

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@SilinMykola SilinMykola force-pushed the 1026-change-overwrite-templates-feature branch from 335368a to fb7224b Compare March 17, 2022 13:47
@bohdan-harniuk bohdan-harniuk force-pushed the 1026-change-overwrite-templates-feature branch from 7626f24 to 903b68d Compare March 18, 2022 11:32
@bohdan-harniuk bohdan-harniuk force-pushed the 1026-change-overwrite-templates-feature branch from 903b68d to 5e10bcd Compare March 18, 2022 11:32
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Thank you, @SilinMykola!

@bohdan-harniuk bohdan-harniuk merged commit 476b4ee into magento:4.3.0-develop Mar 18, 2022
@SilinMykola SilinMykola deleted the 1026-change-overwrite-templates-feature branch March 22, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ArrayIndexOutOfBoundsException in OverrideInThemeDialog.fillThemeOptions
2 participants