Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for "thread context was already set" exception #2082

Merged

Conversation

piotrkwiecinski
Copy link
Contributor

Fixes "thread context was already set" exception triggered on every popup display.

The proper fix is going to be more involved and is tracked in #2080.

I'll pick it up at some point in the future. It's going to require reworking a JDialog implementation to DialogWrapper. It will be more time consuming from implementation and testing point of view.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Contributor

@VitaliyBoyko VitaliyBoyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's do as you propose.

@VitaliyBoyko VitaliyBoyko merged commit e5b0966 into magento:5.3.0-develop Jul 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants