Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changeset tooling #39

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add changeset tooling #39

wants to merge 9 commits into from

Conversation

stigi
Copy link
Contributor

@stigi stigi commented Oct 2, 2024

Change description

This PR adds tooling around managing change sets, by employing https://github.com/changesets/changesets

The source of truth for the project version now relies in package.json and is propagated via a script to all other places (Readme.md, swift sources).

I also imported the last changeset from the current version 2.0.0 as a baseline and added pending changesets for work that was done in #38 and that will go out in a major release.

A few things went into this to make it work:

  • Added NPM configuration and the @changeset dependencies
  • Initialized the changeset config with the default values
  • Added a wrapper around yarn changeset that also calls the update-version.ts script to update the version accross the repo.
  • Cocoapods is fine with loading the version directly via JSON import from package.json

ℹ️ I didn't setup a GitHub workflow yet, as I haven't automated publishing yet

Test Plan

Check out this branch, create an example changeset via yarn changeset or yarn changeset add. Bump the version via yarn changeset version. The version should be updated in package.json, Readme.md as well MagicBellClient.swift.

Type of Change

  • Bug fix
  • Feature
  • Enhancement

@stigi stigi requested a review from smeijer October 2, 2024 22:35
@stigi stigi marked this pull request as ready for review October 2, 2024 22:36
Comment on lines +1 to +11
{
"$schema": "https://unpkg.com/@changesets/config@3.0.3/schema.json",
"changelog": "@changesets/cli/changelog",
"commit": false,
"fixed": [],
"linked": [],
"access": "restricted",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": []
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Didn't look much into them, so please advise for changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant