Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* add file extension #112

Merged
merged 1 commit into from
Jul 7, 2023
Merged

* add file extension #112

merged 1 commit into from
Jul 7, 2023

Conversation

Ethella
Copy link
Member

@Ethella Ethella commented Jul 7, 2023

📦 Pull Request

Fix incompatible issue with Nuxt

ethereum/js-ethereum-cryptography#14

Cannot find module 
'/var/www/slurpeevibe-stage.modeng.dev/private/git/.output/server/node_modules/ethereum-cryptography/keccak' 
imported from /var/www/slurpeevibe-stage.modeng.dev/private/git/.output/server/chunks/index.post.mjs
\nDid you mean to import ethereum-cryptography/keccak.js?

✅ Fixed Issues

🚨 Test instructions

⚠️ Don't forget to add a semver label!

@Ethella Ethella added the patch Increment the patch version when merged label Jul 7, 2023
@Ethella Ethella requested a review from justinnout July 7, 2023 23:01
@Ethella Ethella self-assigned this Jul 7, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #80806: Customer server throws "Cannot find module" error on Magic admin SDK instantiation.

justinnout
justinnout reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@justinnout justinnout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this import change going to break things for existing clients?

@Ethella
Copy link
Member Author

Ethella commented Jul 7, 2023 •
edited
Loading

Is this import change going to break things for existing clients?

Great call, I'm actually testing it

@Ethella
Copy link
Member Author

Ethella commented Jul 7, 2023 •
edited
Loading

image
Compiled successfully on node server

@Ethella Ethella merged commit 97f9235 into master Jul 7, 2023
1 check passed
@Ethella Ethella deleted the jerryliu-sc-80806-customer-server-throws-cannot-find-module branch July 7, 2023 23:20
@magiclabsFE
Copy link

🚀 PR was released in v1.10.1 🚀

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Jul 7, 2023
This was referenced Jun 9, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Jun 17, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Jun 25, 2024
Open
Open
Open
This was referenced Aug 18, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Aug 26, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 2, 2024
Open
Open
Open
Open
Open
Open
Open
@a-gt a-gt mentioned this pull request Sep 12, 2024
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinnout justinnout justinnout approved these changes

Assignees

@Ethella Ethella

Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ethella @magiclabsFE @justinnout