Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESM bundle generation and imports #119

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

romin-halltari
Copy link
Contributor

πŸ“¦ Pull Request

As you can see on this issue our ESM bundle has been broken for quite some time, causing a lot of frustration.

βœ… Fixed Issues

#85
#101

🚨 Test instructions

⚠️ Don't forget to add a semver label!

@romin-halltari romin-halltari added the minor Increment the minor version when merged label Jan 19, 2024
@romin-halltari romin-halltari self-assigned this Jan 19, 2024
Copy link
Member

@Ethella Ethella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romin-halltari romin-halltari merged commit ff4bfea into master Jan 19, 2024
1 check passed
@romin-halltari romin-halltari deleted the PDEEXP-84-Make-the-admin-sdk-ESM-compatible branch January 19, 2024 20:13
@Ethella
Copy link
Member

Ethella commented Jan 19, 2024

πŸš€ PR was released in v2.1.0 πŸš€

@Ethella Ethella added the released This issue/pull request has been released. label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants