feature: make package environment agnostic

[f5io]

📦 Pull Request

This PR makes the @magic-sdk/admin package environment agnostic by

• removing the usage of eth-sig-util and ethereumjs-util that rely heavily on node internals.
• using ethereum-cryptography and some inlined functionality.
• removing usage of node's Buffer in favour of typed arrays.
• shimming node-fetch only where no global fetch implementation is available.
• building both commonjs and esm outputs of the package.

✅ Fixed Issues

• In theory: fixes Ideas to unblock usage in deno? #62, by making this package platform agnostic, it should work in deno although I have not tested.

🚨 Test instructions

All tests pass and coverage is maintained.

I have also created an example of this new @magic-sdk/admin running in a sveltekit application: https://github.com/f5io/magic-link-cloudflare-demo
Here it is actually deployed on cloudflare workers 🎉 : https://magic-link-demo.trustshare.workers.dev/

⚠️ Don't forget to add a semver label!

• minor: New Feature

[smithki]

Your contribution is very appreciated @f5io! Some unfortunate timing that we are currently in the process of moving this SDK source code to the Magic JS monorepo. We expect to have completed the transition next week. At that time we would love to help you translate this PR to the new repo!

[smithki]

This can be updated to import type {... now that an async shim is being used instead

[f5io]

i did attempt to change type imports with the following in the tsconfig.json...

...
    "importsNotUsedAsValues": "error",
...

however, it seems like your current linting set up does not support this syntax :(

[smithki]

We can look at this as a follow-up on our side, in that case!

[f5io]

Your contribution is very appreciated @f5io! Some unfortunate timing that we are currently in the process of moving this SDK source code to the Magic JS monorepo. We expect to have completed the transition next week. At that time we would love to help you translate this PR to the new repo!

absolutely happy to transition these changes into the new monorepo, just let me know when you are ready 👍

[smithki]

Priorities shifted a bit and we'll be delaying the merging of this package into our JS monorepo for now. Just a heads up that I'll be reviewing your change shortly and hopefully we can cut a release by end-of-week!

[smithki]

@f5io We have updated our test framework to use Jest in order to align this repository with the code standards in our monorepo. This change does create a few minor conflicts in your PR. Once we can get those sorted, I'm happy to ship this one!

[f5io]

@smithki on it... will sort asap

[f5io]

@smithki rebased my branch from your master, everything seems to be passing as intended 👍

[f5io]

hey @smithki, just bumping this...

we're planning on going into production with this approach in a couple of weeks. obviously, i'm more than happy to roll with pointing at my fork for now.

[liam0215]

I'd like to bump this as well, I think this'll get me unblocked from using Magic with Convex

[3x071c]

@smithki Don't want to annoy anybody, but I've been encountering similar issues with Remix on Cloudflare Pages (running on dynamic workers functions, which don't run full-blown Node.js for efficiency). Would greatly appreciate having this integrated!

[smithki]

🚀 PR was released in v1.4.0 🚀