Add shims for atob #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #50572: Admin-js Malformed Token on deployment. |
| import atob from 'atob'; | ||
|
|
||
| // Shims for atob being undefined in node.js prior version 14 | ||
| if (!globalThis.atob) globalThis.atob = atob; |
There was a problem hiding this comment.
@Ethella Looks good to me. Just dropped the test coverage too low 🤣
There was a problem hiding this comment.
Wasn't aware of tests 😭. Will make them
dgerrellsMagic
previously approved these changes
Apr 15, 2022
mushfichowdhury-magic
previously approved these changes
Apr 15, 2022
Ethella
dismissed stale reviews from mushfichowdhury-magic and dgerrellsMagic
via
82c65d4
Ethella
deleted the
jerryliu-sc-50572-admin-js-malformed-token-on-deployment
branch
|
🚀 PR was released in |
3 tasks
This was referenced Jun 9, 2024
This was referenced Jun 17, 2024
This was referenced Aug 18, 2024
This was referenced Aug 26, 2024
This was referenced Sep 2, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
Add shims for atob
✅ Fixed Issues
Fixes #86
🚨 Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
patch: Bug Fix?minor: New Feature?major: Breaking Change?skip-release: It's unnecessary to publish this change.