Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] User authentication #267

Open
3dhobbies opened this issue Apr 21, 2021 · 15 comments
Open

[FR] User authentication #267

3dhobbies opened this issue Apr 21, 2021 · 15 comments
Labels
Is: UI/UX Anything referencing UI/UX Prio: 2 Medium 🚦 Status: 1 - Ready 💡 Type: FR Requests a new feature
Milestone

Comments

@3dhobbies
Copy link

Is your feature request related to a problem? Please describe.
Not a bug or so, basically a security concern when logging in from external domain (internet). i have done a port forward to my specific printer, and cannot find a way to force the mainsailos to ask for login credentials.

Describe the solution you'd like
A basic secure login screen. forcing a user to log into the mainsailos when logging on.

Describe alternatives you've considered
Cannot find any other way of securing the mainsailos install on my pi

Additional context
Add any other context or screenshots about the feature request here.

@meteyou
Copy link
Member

meteyou commented Apr 22, 2021

please do not use port forwarding on your printer! no matter if mainsail, octoprint or anything else is running on the printer! none of these systems were ever built for such a use. please use a secure vpn connection to your network.

apparently, some kind of login has now been integrated into moonraker, so i can also integrate it into mainsail, but it is still not a solution to access the printer via the internet.

@3dhobbies
Copy link
Author

3dhobbies commented Apr 22, 2021 via email

@JellevanKraaij
Copy link

I love to see support for the moonraker authentication functionality as well, hope it gets implemented soon! Just switched from fluidd to mainsail, but the authentication is the only thing that I find really missing.

Thanks a lot!!

@lixxbox lixxbox added Prio: 2 Medium Is: UI/UX Anything referencing UI/UX 💡 Type: Improve Requests an improvement 🚦 Status: 1 - Ready labels Jan 17, 2022
@kubik369
Copy link

Does it make sense to reinvent the wheel instead of using something like basic auth in nginx? OP is saying that he could not find any other way, but this seems to fit the bill perfectly, since kiauh already sets nginx up and all :)

@meteyou
Copy link
Member

meteyou commented Jan 26, 2022

moonraker authentication does have certain advantages. furthermore, it is also nicer integrated in the gui.

@dw-0 dw-0 added 💡 Type: FR Requests a new feature and removed 💡 Type: Improve Requests an improvement labels Feb 14, 2022
@dohlin
Copy link

dohlin commented Feb 23, 2022

Switched from Fluidd to Mainsail and this is about the only thing I'm greatly missing. Definitely a nice to have!

@dw-0 dw-0 added this to the v2.3.0 milestone Jun 10, 2022
@tfjield
Copy link

tfjield commented Jul 17, 2022

Is it possible to use basic auth in nginx? I've tried it, but after I provide credentials and Mainsail loads, it can't connect to Moonraker.

@dw-0 dw-0 modified the milestones: v2.3.0, vNext Aug 2, 2022
@dw-0 dw-0 changed the title [FR]Login screen.... [FR] User authentication Aug 2, 2022
@rroethof
Copy link

rroethof commented Sep 9, 2022

Currently using Fluidd in combo with moonraker and in this network any network listener without a form of authentication is not an option.
Therefore support for the moonraker auth is a much wanted request here.

@meteyou meteyou mentioned this issue Nov 10, 2022
@MabaKalox
Copy link

@meteyou hi! How can I help adding this feature?

@meteyou
Copy link
Member

meteyou commented Apr 22, 2023

@MabaKalox hey! It would be very nice if you had time to finish the implementation! I started the implementation months ago here: #370, but i haven't time to finish it.

The PR draft is very, very, very old. Starting with a new fork is more uncomplicated than updating my old branch.

@meteyou
Copy link
Member

meteyou commented Apr 22, 2023

ahh sry. this was my implementation: https://github.com/meteyou/mainsail-dev/tree/feature/authorization

the PR above was from another guy.

@MabaKalox
Copy link

@meteyou Thank you, I will take a look.

@Robnex
Copy link

Robnex commented Aug 27, 2023

Hi. what's the status of the authentification implementation?

@midikeyboard
Copy link

Hi. what's the status of the authentification implementation?

its open on the roadmap. i currently run mainsail behind nginx proxy with a access list to authenticate while having public access. if you need authentication this is the way to go (for now).

@meteyou
Copy link
Member

meteyou commented Aug 29, 2023

@midikeyboard even if the authentication of Moonraker is integrated, this feature is NOT made for public access!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Is: UI/UX Anything referencing UI/UX Prio: 2 Medium 🚦 Status: 1 - Ready 💡 Type: FR Requests a new feature
Projects
None yet
Development

No branches or pull requests