Adding alternate version of tonepie cat litter box #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be useful to understand what you mean by "alternate version". In general, I don't want multiple personal preferences for configs for a single device in the repository. There are too many configs for distinct devices as it is. |
|
The device I've bought has a completely different set of IDs compared to the tonepie T1 pro that is in the repository already. Since my device was named tonepie T1 pro too,I named it "alternate". |
…e_t1pro_catlitterbox_v2.yaml v2 is preferred to alternate, since it leaves the possibility of v3 etc open in case there are more variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.