Add support for Reiga ceiling fan without light #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make-all
reviewed
Sep 27, 2024
custom_components/tuya_local/devices/reiga_ceiling_fan_with_light.yaml
Outdated
Show resolved
Hide resolved
DennisGeisse
force-pushed
the
reiga-ceiling-fan
branch
from
51cc9d7
to
c8b3c74
Compare
make-all
added a commit
that referenced
this pull request
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added a device description for Reiga smart ceiling fans that do not have an integrated light. Tested with the fan that I have installed at home (this model).
In addition, I propose to change the naming of a similar file, the one that describes fans from the same manufacturer with integrated lights (reiga_52_fan_light.yaml). The naming of the previously existing file suggests that it is only valid for fans with this specific size of the blades (52 inch), which I consider an unnecessary limitation of the scope. Like with the Windcalm fans I think it is fair to just differentiate between fans with or without light.
Apologies if my edit to DEVICES.md messed up whitespaces in two locations, these were not intended.