Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added goldair tower fan config #844

Merged
merged 4 commits into from
Jul 2, 2023
Merged

Added goldair tower fan config #844

merged 4 commits into from
Jul 2, 2023

Conversation

horse-pants
Copy link

Tested with two fans at my home

@horse-pants
Copy link
Author

The product name coming out of the tuya APIs is all upper case, so I copied it in the same because I wasn't sure if they had to match.

If the casing doesn't matter I can make it normal casing

@BenJamesAndo
Copy link
Contributor

BenJamesAndo commented Jun 28, 2023 •
edited
Loading

I have the Goldair 101cm Electronic Tower Fan. Thanks to your code I modified it a bit to match mine, which is a little different.
But your fan should also support temperature. I added this to mine and it now gets the current temperature reading.

- id: 21
  type: integer
  name: temperature
  unit: C
  range:
    min: 4
    max: 35

@horse-pants
Copy link
Author

Ah true, I forgot about the temp sensor.

I'll add this tonight, thanks

@BenJamesAndo BenJamesAndo mentioned this pull request Jun 29, 2023
Closed
@make-all make-all merged commit a70d0b8 into make-all:main Jul 2, 2023
4 checks passed
make-all added a commit that referenced this pull request Jul 2, 2023
@make-all
Update docs for recent pull requests.
caffbcf 
PR #839, #840, #844, #849, #851

Also added a variation of #858 (preference is to note compatible
devices alongside the original device that implements them).
timlaing pushed a commit to timlaing/tuya-local that referenced this pull request Jul 2, 2023
@make-all @timlaing
Update docs for recent pull requests.
22d56cd 
PR make-all#839, make-all#840, make-all#844, make-all#849, make-all#851

Also added a variation of make-all#858 (preference is to note compatible
devices alongside the original device that implements them).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@make-all make-all make-all left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@horse-pants @BenJamesAndo @make-all