add PV28-CW air quality monitor #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make-all
reviewed
Jul 27, 2023
| unit: µg/m³ | ||
| class: measurement | ||
| - entity: sensor | ||
| name: Humidity |
There was a problem hiding this comment.
There is already a sensor called humidity on dp 19. This one needs a unique name to differentiate it.
There was a problem hiding this comment.
they're basically the same and both are reported. i've made the 103 hidden: true
There was a problem hiding this comment.
Making it hidden does not solve the issue of the name clash. If it is not useful as a sensor in its own right, then the dp should be listed as an extra attribute on some other entity rather than being a sensor entity of its own.
custom_components/tuya_local/devices/pv28-cw_airquality_monitor.yaml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Ggele PV28-CW air quality monitor
some dp's are commented out because they don't work but are listed as supported in iot.tuya.com