Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix public key parsing logic #29

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

koltsov-iv
Copy link
Member

Fix public key parsing logic

Fix issue:

{"cl_type":{"List":"PublicKey"},"bytes":"02000000010e31a03ea026a8e375653573e0120c8cb96699e6c9721ae1ea98f896e6576ac30193b3800386aefe11648150f6779158f2c7e1233c8e9b423338eb71b93ae6c5a9","parsed":["010e31a03ea026a8e375653573e0120c8cb96699e6c9721ae1ea98f896e6576ac3","0193b3800386aefe11648150f6779158f2c7e1233c8e9b423338eb71b93ae6c5a9"]}

Unable to parse to CLValue. With error - invalid public key algorithm

Also, found that ed25519.NewPublicKey has no size validation and just wraps incoming bytes to PublicKey type.

Checklist

  • Code is properly formatted
  • All commits are signed
  • Tests included/updated or not needed
  • Documentation (manuals or wiki) has been updated or is not required

@koltsov-iv koltsov-iv changed the base branch from master to release/v1.1.4 June 27, 2023 13:12
@koltsov-iv koltsov-iv merged commit 1072d00 into release/v1.1.4 Jun 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants