-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add test case for validator bug reproduction
- Loading branch information
Showing
7 changed files
with
130 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package com.example; | ||
|
||
import com.example.validation.ValidInternalId; | ||
import com.example.validation.ValidatedByFactory; | ||
import io.micronaut.core.annotation.Introspected; | ||
|
||
@Introspected | ||
public record ValidatedBean( | ||
@ValidatedByFactory | ||
String value, | ||
@ValidInternalId | ||
int internalId) { | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
package com.example.validation; | ||
|
||
import jakarta.validation.Constraint; | ||
import jakarta.validation.constraints.Max; | ||
import jakarta.validation.constraints.NotNull; | ||
import jakarta.validation.constraints.Positive; | ||
|
||
import java.lang.annotation.*; | ||
|
||
@Documented | ||
@Constraint(validatedBy = {}) | ||
@Target( | ||
{ | ||
ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, ElementType.ANNOTATION_TYPE, ElementType.CONSTRUCTOR, ElementType.TYPE_USE | ||
} | ||
) | ||
@Retention(RetentionPolicy.RUNTIME) | ||
@NotNull | ||
@Positive | ||
@Max(Integer.MAX_VALUE) | ||
public @interface ValidInternalId { | ||
} |
18 changes: 18 additions & 0 deletions
18
src/main/java/com/example/validation/ValidatedByFactory.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package com.example.validation; | ||
|
||
import jakarta.validation.Constraint; | ||
import jakarta.validation.constraints.Size; | ||
|
||
import java.lang.annotation.*; | ||
|
||
@Documented | ||
@Constraint(validatedBy = {}) | ||
@Target( | ||
{ | ||
ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, ElementType.ANNOTATION_TYPE, ElementType.CONSTRUCTOR, ElementType.TYPE_USE | ||
} | ||
) | ||
@Retention(RetentionPolicy.RUNTIME) | ||
@Size(max = 32) | ||
public @interface ValidatedByFactory { | ||
} |
18 changes: 18 additions & 0 deletions
18
src/main/java/com/example/validation/ValidatorFactory.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package com.example.validation; | ||
|
||
import io.micronaut.context.annotation.Factory; | ||
import io.micronaut.core.annotation.Introspected; | ||
import io.micronaut.validation.validator.constraints.ConstraintValidator; | ||
import jakarta.inject.Singleton; | ||
|
||
@Factory | ||
@Introspected | ||
public class ValidatorFactory { | ||
|
||
@Singleton | ||
ConstraintValidator<ValidatedByFactory, CharSequence> validatedByFactoryValidator() { | ||
return (ignored1, ignored2, ignored3) -> true; | ||
} | ||
|
||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
package com.example; | ||
|
||
import io.micronaut.test.extensions.junit5.annotation.MicronautTest; | ||
import jakarta.inject.Inject; | ||
import jakarta.validation.ConstraintViolation; | ||
import jakarta.validation.Validator; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
@MicronautTest(rebuildContext = true, startApplication = false) | ||
public class ValidatorTest { | ||
|
||
@Inject | ||
Validator validator; | ||
|
||
@Test | ||
void BUG_REPRODUCTION_CASE_validateValidBean_shouldNotFail() { | ||
var bean = new ValidatedBean("foobar", 42); | ||
|
||
assertThat(validator.validate(bean)).isEmpty(); | ||
} | ||
|
||
@Test | ||
void validateValidBean_workaround() { | ||
var validBean = new ValidatedBean("foobar", 42); | ||
|
||
warmUpValidator(validBean); | ||
|
||
assertThat(validator.validate(validBean)).isEmpty(); | ||
} | ||
|
||
@Test | ||
void validateInvalidBean_shouldFail() { | ||
var invalidBean = new ValidatedBean("foobar", -123); | ||
|
||
warmUpValidator(invalidBean); | ||
|
||
assertThat(validator.validate(invalidBean)) | ||
.singleElement() | ||
.returns(-123, ConstraintViolation::getInvalidValue); | ||
} | ||
|
||
|
||
/** | ||
* Workaround for the bug | ||
*/ | ||
private void warmUpValidator(ValidatedBean validBean) { | ||
try { | ||
validator.validate(validBean); | ||
} catch (Exception e) { | ||
System.out.println(e); | ||
} | ||
} | ||
} |