fix the scope of some rules with dependencies #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-tz
reviewed
Jun 6, 2024
Comment on lines
+9
to
+10
| static: instruction | ||
| dynamic: call |
There was a problem hiding this comment.
with the optional part we're targeting multiple API calls which won't work this way
There was a problem hiding this comment.
ah, right...
I'm inclined to remove the optional and let this be used as a dependency more widely. Thoughts?
There was a problem hiding this comment.
or relax scope to basic block
There was a problem hiding this comment.
I'd say it's fine to remove the optional block, how about we create a new rule with the LoadLibrary APIs (not sure if that's just noisy or helpful).
mike-hunhoff
reviewed
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: mandiant/capa#2124