-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into feat/echidna-erc4626-tests
- Loading branch information
Showing
16 changed files
with
250 additions
and
157 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule solady
deleted from
a549da
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /// SPDX: License-Identifier: GPL-3.0-only | ||
| pragma solidity 0.8.19; | ||
|
|
||
| import "../MevEthTest.sol"; | ||
|
|
||
| contract WithdrawalQueueAttackTest is MevEthTest { | ||
| function testDosAttackQueueLength() public { | ||
| vm.deal(User01, 63 ether); | ||
| vm.startPrank(User01); | ||
|
|
||
| IStakingModule.ValidatorData memory validatorData = mockValidatorData(User01, 32 ether / 1 gwei); | ||
|
|
||
| // 1. Attacker deposits 63 Eth to MevEth | ||
| weth.deposit{ value: 63 ether }(); | ||
| weth.approve(address(mevEth), 63 ether); | ||
| mevEth.deposit(63 ether, User01); | ||
| assertEq(address(mevEth).balance, 63 ether); | ||
|
|
||
| // 2. `createValidator()` is called -> MevEth balance 31 Ether | ||
| vm.stopPrank(); | ||
| vm.startPrank(Operator01); | ||
| mevEth.createValidator(validatorData); | ||
| assertEq(address(mevEth).balance, 31 ether); | ||
|
|
||
| vm.stopPrank(); | ||
| vm.startPrank(User01); | ||
| // 3. Attackers withdraws 31 ETH -> MevEth balance 0 Ether | ||
| mevEth.withdraw(31 ether, User01, User01); | ||
| assertEq(address(mevEth).balance, 0 ether); | ||
|
|
||
| // 4. Attackers shares are still worth 32 ether | ||
| assertEq(mevEth.convertToAssets(mevEth.balanceOf(User01)), 32 ether); | ||
|
|
||
| // ~10 blocks worth of txs | ||
| for (uint256 i = 0; i < 1000; i++) { | ||
| // Attacker withdraws 0.01 ETH worth of shares, but because contract has no balance left the queueLength increases by 1. | ||
| // Attacker repeats step above many times. | ||
| mevEth.withdraw(0.011 ether, User01, User01); | ||
| } | ||
|
|
||
| vm.stopPrank(); | ||
| vm.startPrank(Operator01); | ||
| // Give mevEth enough ether to process all withdrawals | ||
| vm.deal(address(mevEth), 100 ether); | ||
|
|
||
| // Block gas limit | ||
| mevEth.processWithdrawalQueue(mevEth.queueLength()); | ||
| for (uint256 i = 1; i < 1001; i++) { | ||
| mevEth.claim(i); | ||
| } | ||
| assertEq(weth.balanceOf(User01), 42 ether); | ||
| assertEq(mevEth.queueLength(), 1000); | ||
| assertEq(mevEth.requestsFinalisedUntil(), 1000); | ||
| assertEq(mevEth.withdrawalAmountQueued(), 0); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| pragma solidity 0.8.19; | ||
|
|
||
| import "forge-std/console.sol"; | ||
| import "../MevEthTest.sol"; | ||
| import "src/interfaces/Errors.sol"; | ||
| import "src/MevEthRateProvider.sol"; | ||
| import "src/interfaces/IMevEth.sol"; | ||
|
|
||
| contract MevEthRateProviderTest is MevEthTest { | ||
| MevETHRateProvider provider; | ||
|
|
||
| function setUp() public override { | ||
| super.setUp(); | ||
| provider = new MevETHRateProvider(IMevEth(address(mevEth))); | ||
| } | ||
|
|
||
| function testRate() public { | ||
| assertEq(provider.getRate(), 1 ether); | ||
| } | ||
|
|
||
| function testRateUpdate() public { | ||
| vm.deal(address(this), 10 ether); | ||
| mevEth.deposit{ value: 10 ether }(10 ether, address(this)); | ||
| address staker = address(mevEth.stakingModule()); | ||
| vm.deal(staker, 2 ether); | ||
| vm.prank(SamBacha); | ||
| IStakingModule(staker).payRewards(); | ||
| assertGt(provider.getRate(), 1 ether); | ||
| } | ||
| } |
Oops, something went wrong.