Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript 5.4 errors due to outdated type-fest version #5891

Closed
1 of 2 tasks
SantoJambit opened this issue Mar 8, 2024 · 1 comment
Closed
1 of 2 tasks

TypeScript 5.4 errors due to outdated type-fest version #5891

SantoJambit opened this issue Mar 8, 2024 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@SantoJambit
Copy link

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.6.1

What package has an issue?

@mantine/core

What framework do you use?

Vite

In which browsers you can reproduce the issue?

Not applicable – issue is not related to the browser

Describe the bug

TypeScript 5.4 caused an issue with type-fest: sindresorhus/type-fest#784
This has been fixed as can be seen in the linked issue.

Error logs:

Error: node_modules/@mantine/core/node_modules/type-fest/source/merge-deep.d.ts(140,5): error TS2321: Excessive stack depth comparing types 'PickRestType<ArrayTail<ArrayTail<Destination>>>[number]' and 'UnknownArrayOrTuple'.
Error: node_modules/@mantine/core/node_modules/type-fest/source/merge-deep.d.ts(140,5): error TS2321: Excessive stack depth comparing types 'PickRestType<ArrayTail<ArrayTail<Destination>>>[number]' and 'UnknownRecord'.
Error: node_modules/@mantine/core/node_modules/type-fest/source/merge-deep.d.ts(140,5): error TS2321: Excessive stack depth comparing types 'PickRestType<ArrayTail<ArrayTail<Source>>>[number]' and 'UnknownArrayOrTuple'.
Error: node_modules/@mantine/core/node_modules/type-fest/source/merge-deep.d.ts(166,5): error TS2321: Excessive stack depth comparing types 'PickRestType<ArrayTail<ArrayTail<Destination>>>[number]' and 'UnknownArrayOrTuple'.
Error: node_modules/@mantine/core/node_modules/type-fest/source/merge-deep.d.ts(166,5): error TS2321: Excessive stack depth comparing types 'PickRestType<ArrayTail<ArrayTail<Destination>>>[number]' and 'UnknownRecord'.
Error: node_modules/@mantine/core/node_modules/type-fest/source/merge-deep.d.ts(166,5): error TS2321: Excessive stack depth comparing types 'PickRestType<ArrayTail<ArrayTail<Source>>>[number]' and 'UnknownArrayOrTuple'.
Error: node_modules/@mantine/core/node_modules/type-fest/source/merge-deep.d.ts(192,5): error TS2321: Excessive stack depth comparing types 'PickRestType<ArrayTail<ArrayTail<Destination>>>[number]' and 'UnknownArrayOrTuple'.
Error: node_modules/@mantine/core/node_modules/type-fest/source/merge-deep.d.ts(192,5): error TS2[32](https://github.com/RedaktionsNetzwerk-Deutschland/one-fusion/actions/runs/8181139181/job/22370424815?pr=4303#step:7:33)1: Excessive stack depth comparing types 'PickRestType<ArrayTail<ArrayTail<Destination>>>[number]' and 'UnknownRecord'.
Error: node_modules/@mantine/core/node_modules/type-fest/source/merge-deep.d.ts(192,5): error TS2321: Excessive stack depth comparing types 'PickRestType<ArrayTail<ArrayTail<Source>>>[number]' and 'UnknownArrayOrTuple'.

If possible, include a link to a codesandbox with a minimal reproduction

No response

Possible fix

Update type-fest version to at least 4.10.2

Self-service

  • I would be willing to implement a fix for this issue
@Kenzo-Wada Kenzo-Wada mentioned this issue Mar 9, 2024
Closed
@eMerzh eMerzh mentioned this issue Mar 11, 2024
Merged
BenoitZugmeyer added a commit to DataDog/browser-sdk that referenced this issue Mar 12, 2024
@BenoitZugmeyer
fix a typescript 5.4.2 regression causing typechecking to fail
bfa8824 
See:
* sindresorhus/type-fest#784
* mantinedev/mantine#5891
BenoitZugmeyer added a commit to DataDog/browser-sdk that referenced this issue Mar 12, 2024
@renovate @BenoitZugmeyer
👷 Update all non-major dependencies (#2637)
2e44e2e 
* 👷 Update all non-major dependencies

* fix a typescript 5.4.2 regression causing typechecking to fail

See:
* sindresorhus/type-fest#784
* mantinedev/mantine#5891

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoît Zugmeyer <benoit.zugmeyer@datadoghq.com>
rtivital added a commit that referenced this issue Mar 12, 2024
@rtivital
[@mantine/core] Fix some functions not working correctly with TypeScr…
03133fb 
…ipt 5.4 (#5891)
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Mar 12, 2024
@rtivital
Copy link
Member

Fixed in 7.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[@mantine/core] Update type-fest@^3.13.0 -> @^4.12.0 Kenzo-Wada/mantine
2 participants
@rtivital @SantoJambit