Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FocusTrap relies on a deprecated feature in React 19 #6492

Closed
1 of 2 tasks
paulzakin opened this issue Jul 5, 2024 · 2 comments
Closed
1 of 2 tasks

FocusTrap relies on a deprecated feature in React 19 #6492

paulzakin opened this issue Jul 5, 2024 · 2 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@paulzakin
Copy link

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.11.1

What package has an issue?

@mantine/core

What framework do you use?

Other, I will specify in the bug description

In which browsers you can reproduce the issue?

Chrome

Describe the bug

Hello!

I'm getting a warning when using Mantine and React 19. I posted the message and stack trace below. It seems spiritually similar to #6446. Just thought I would give you a heads up - apologize if this warning is not helpful. It still works, as far as I can tell, so it is not urgent, at least for me. Thanks!

Accessing element.ref was removed in React 19. ref is now a regular prop. It will be removed from the JSX Element type in a future release.

    at FocusTrap (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:5475:3)
    at Transition (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:5786:3)
    at @mantine/core/Portal (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:5509:43)
    at OptionalPortal (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:5534:33)
    at @mantine/core/PopoverDropdown (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:5833:17)
    at @mantine/core/ComboboxDropdown (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:11684:80)
    at OptionsDropdown (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:12502:3)
    at Provider (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:5372:23)
    at Popover (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:6089:17)
    at Provider (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:5372:23)
    at Combobox (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:12287:17)
    at @mantine/core/Select (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:14964:17)
    at div
    at @mantine/core/Box (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:2661:3)
    at Widget (https://127.0.0.1/build/chunk-5b3443c25c7fa3be.js:10013:11)
    at SelectWidget (https://127.0.0.1/build/chunk-5b3443c25c7fa3be.js:13279:21)
    at div
    at @mantine/core/Box (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:2661:3)
    at @mantine/core/Stack (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:9612:17)
    at div
    at @mantine/core/Box (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:2661:3)
    at @mantine/core/Stack (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:9612:17)
    at WidgetRenderer (https://127.0.0.1/build/chunk-5b3443c25c7fa3be.js:13486:11)
    at WidgetAssembler (https://127.0.0.1/build/chunk-5b3443c25c7fa3be.js:13652:11)
    at div
    at @mantine/core/Box (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:2661:3)
    at @mantine/core/Stack (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:9612:17)
    at Section
    at form
    at div
    at @mantine/core/Box (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:2661:3)
    at JsonForm (https://127.0.0.1/build/chunk-5b3443c25c7fa3be.js:13757:29)
    at div
    at @mantine/core/Box (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:2661:3)
    at @mantine/core/Stack (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:9612:17)
    at div
    at @mantine/core/Box (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:2661:3)
    at @mantine/core/Stack (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:9612:17)
    at Table2 (https://127.0.0.1/build/chunk-84dfbb7a8b45d5fd.js:60:3)
    at div
    at @mantine/core/Box (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:2661:3)
    at @mantine/core/Stack (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:9612:17)
    at QueryClientProvider (https://127.0.0.1/build/chunk-b5fea44eeb1891b0.js:2061:3)
    at PageDataProvider (https://127.0.0.1/build/chunk-6c0261ee02025288.js:894:3)
    at MantineThemeProvider (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:1624:3)
    at MantineProvider (https://127.0.0.1/build/chunk-11d2a476aae9fa5a.js:2057:3)
    at ErrorBoundary (https://127.0.0.1/build/chunk-6c0261ee02025288.js:61:5)

If possible, include a link to a codesandbox with a minimal reproduction

No response

Possible fix

No response

Self-service

  • I would be willing to implement a fix for this issue
@paulzakin paulzakin changed the title FocusTrap relies on deprecated feature in React 19 FocusTrap relies on a deprecated feature in React 19 Jul 5, 2024
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Jul 12, 2024
@rtivital
Copy link
Member

Fixed in 7.11.2

@paulzakin
Copy link
Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants