Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am going to merge this but noting that the DataCite infrastructure that contains the DOI metadata for this DOI is currently failing, so our CI likely will fail. I was able to get metadata from the actual website like:
I think the best course is for us to merge this and then figure out the best way to workaround these DataCite failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this happened even with manubot 0.5.2, right? We can discuss this elsewhere, but maybe falling back to Zotero with the DOI URL
https://doi.org/10.5278/ojs.quivirr.v1.2020.a0001
could be a last resort attempt to retrieve DOI metadata.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes with 0.5.2.
I agree this is a good next step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not have trouble with this DOI with Manubot in 2021. It is only since the new year (and updating to 0.5.2) that this happened. And GitHub Actions build times are lately 3-5 times as long. No idea why... but the main processing hike is with the Build Manuscript.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skandilocks one of the main APIs citation metadata is getting pulled from has been having issues, see crosscite/content-negotiation#104 (comment).
One thing that will speed things up tremendously is to cache reference metadata like: