Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'in' filters can be slow when iterating with the returned filter function #8

Closed
dcervelli opened this issue Jan 27, 2016 · 0 comments
Closed

'in' filters can be slow when iterating with the returned filter function #8

dcervelli opened this issue Jan 27, 2016 · 0 comments

Comments

@dcervelli
Copy link

'in' filters are implemented with m, the number of elements in the filter, inline if statements. When calling the filter function while iterating over a list of features of length n this leads to O(m*n) run-time, which can be really slow.
@dcervelli dcervelli mentioned this issue Jan 28, 2016
Closed
mourner added a commit that referenced this issue Jan 29, 2016
@mourner
fast eval-less filter implementation
9ba624b 
Closes #6, closes #8, closes #10.
@mourner mourner mentioned this issue Jan 29, 2016
Closed
mourner added a commit that referenced this issue Jan 29, 2016
@mourner
faster and simpler filter implementation
55aecbb 
Closes #6, closes #10, ref #8.
@mourner mourner mentioned this issue Jan 29, 2016
Merged
mourner added a commit that referenced this issue Jan 29, 2016
@mourner
faster and simpler filter implementation
b4bc18d 
Closes #6, closes #10, ref #8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcervelli