Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw removes boxZoom but never restores it on removal #571

Closed
averas opened this issue Dec 29, 2016 · 5 comments · Fixed by #1017
Closed

Draw removes boxZoom but never restores it on removal #571

averas opened this issue Dec 29, 2016 · 5 comments · Fixed by #1017
Labels
bug ui Buttons & user interactions

Comments

@averas
Copy link
Contributor

averas commented Dec 29, 2016

During setup Draw removes boxZoom (to be able to provide shift-box-selections instead):

map.boxZoom.disable();

But when draw is removed it never tries to enable it again.

andrewharvey added a commit to andrewharvey/mapbox-gl-draw that referenced this issue Jan 19, 2017
@andrewharvey
Copy link
Collaborator

I tried to implement this in andrewharvey@1d72e54, but it's not ready for PR because when testing it seems like the map becomes stuck in pan mode...

@averas
Copy link
Contributor Author

averas commented Jan 19, 2017

Probably related to mapbox/mapbox-gl-js#2237

andrewharvey added a commit to andrewharvey/mapbox-gl-draw that referenced this issue Jan 19, 2017
@andrewharvey
Copy link
Collaborator

Probably related to mapbox/mapbox-gl-js#2237

That sounds like the exact issue, will have to wait for that to be resolved before this issue can be addressed.

@mvl22
Copy link

mvl22 commented Apr 14, 2019

Can anyone suggest a workaround for this?

@kkaefer kkaefer added bug ui Buttons & user interactions and removed bug-confirmed labels Jan 7, 2020
@kibala145
Copy link
Contributor

As a workaround call map.boxZoom.enable() after removeControl manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ui Buttons & user interactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants