Auto-convert format arguments to strings

mapbox · Sep 13, 2018 · 3b480cd · 3b480cd
1 parent 1ff116c
commit 3b480cd
Show file tree

Hide file tree

Showing 4 changed files with 52 additions and 2 deletions.
diff --git a/src/style-spec/expression/definitions/formatted.js b/src/style-spec/expression/definitions/formatted.js
@@ -1,7 +1,7 @@
 // @flow
 
 import { NumberType, ValueType, FormattedType, array, StringType } from '../types';
-
+import { toString } from '../values';
 
 import type { Expression } from '../expression';
 import type EvaluationContext from '../evaluation_context';
@@ -101,7 +101,7 @@ export class FormatExpression implements Expression {
         return new Formatted(
             this.sections.map(section =>
                 new FormattedSection(
-                    section.text.evaluate(ctx) || "",
+                    toString(section.text.evaluate(ctx)),
                     section.scale ? section.scale.evaluate(ctx) : null,
                     section.font ? section.font.evaluate(ctx).join(',') : null
                 )

diff --git a/...xpression-tests/formatted/basic/test.json → ...n/expression-tests/format/basic/test.json b/...xpression-tests/formatted/basic/test.json → ...n/expression-tests/format/basic/test.json
diff --git a/test/integration/expression-tests/format/coercion/test.json b/test/integration/expression-tests/format/coercion/test.json
@@ -0,0 +1,50 @@
+{
+  "expression": [
+    "format",
+    ["get", "a"],
+    {},
+    ["get", "1"],
+    {},
+    ["get", "true"],
+    {}
+  ],
+  "inputs": [[{}, {"properties": {"a": "a", "1": 1, "true": true}}]],
+  "expected": {
+    "compiled": {
+      "result": "success",
+      "isFeatureConstant": false,
+      "isZoomConstant": true,
+      "type": "formatted"
+    },
+    "outputs": [
+      {
+        "sections": [
+          {
+            "text": "a",
+            "scale": null,
+            "fontStack": null
+          },
+          {
+            "text": "1",
+            "scale": null,
+            "fontStack": null
+          },
+          {
+            "text": "true",
+            "scale": null,
+            "fontStack": null
+          }
+        ]
+      }
+    ],
+    "serialized": [
+      "format",
+      ["get", "a"],
+      {},
+      ["get", "1"],
+      {},
+      ["get", "true"],
+      {}
+    ]
+  }
+}
diff --git a/...ssion-tests/formatted/to-string/test.json → ...pression-tests/format/to-string/test.json b/...ssion-tests/formatted/to-string/test.json → ...pression-tests/format/to-string/test.json