Support collators in feature filter expressions.

Fixes issue #6920: feature filters using collator expressions would incorrectly be treated as legacy filters.
mapbox · Jul 9, 2018 · f73f7e2 · f73f7e2
1 parent 2a66237
commit f73f7e2
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/src/style-spec/feature_filter/index.js b/src/style-spec/feature_filter/index.js
@@ -28,7 +28,7 @@ function isExpressionFilter(filter: any) {
     case '>=':
     case '<':
     case '<=':
-        return filter.length === 3 && (Array.isArray(filter[1]) || Array.isArray(filter[2]));
+        return filter.length !== 3 || (Array.isArray(filter[1]) || Array.isArray(filter[2]));
 
     case 'any':
     case 'all':
@@ -153,4 +153,3 @@ function convertHasOp(property: string) {
 function convertNegation(filter: mixed) {
     return ['!', filter];
 }
-
diff --git a/test/unit/style-spec/feature_filter.test.js b/test/unit/style-spec/feature_filter.test.js
@@ -24,6 +24,19 @@ test('filter', (t) => {
         t.end();
     });
 
+    t.test('expression, collator comparison', (t) => {
+        const caseSensitive = filter(['==', ['string', ['get', 'x']], ['string', ['get', 'y']], ['collator', { 'case-sensitive': true }]]);
+        t.equal(caseSensitive({zoom: 0}, {properties: {x: 'a', y: 'b'}}), false);
+        t.equal(caseSensitive({zoom: 0}, {properties: {x: 'a', y: 'A'}}), false);
+        t.equal(caseSensitive({zoom: 0}, {properties: {x: 'a', y: 'a'}}), true);
+
+        const caseInsensitive = filter(['==', ['string', ['get', 'x']], ['string', ['get', 'y']], ['collator', { 'case-sensitive': false }]]);
+        t.equal(caseInsensitive({zoom: 0}, {properties: {x: 'a', y: 'b'}}), false);
+        t.equal(caseInsensitive({zoom: 0}, {properties: {x: 'a', y: 'A'}}), true);
+        t.equal(caseInsensitive({zoom: 0}, {properties: {x: 'a', y: 'a'}}), true);
+        t.end();
+    });
+
     t.test('expression, any/all', (t) => {
         t.equal(filter(['all'])(), true);
         t.equal(filter(['all', true])(), true);
@@ -52,7 +65,6 @@ test('filter', (t) => {
         t.end();
     });
 
-
     t.test('degenerate', (t) => {
         t.equal(filter()(), true);
         t.equal(filter(undefined)(), true);

diff --git a/test/unit/style-spec/fixture/filters.output.json b/test/unit/style-spec/fixture/filters.output.json
@@ -12,11 +12,11 @@
     "line": 29
   },
   {
-    "message": "layers[3].filter: filter array for operator \"==\" must have 3 elements",
+    "message": "layers[3].filter: Expected two or three arguments.",
     "line": 40
   },
   {
-    "message": "layers[4].filter: filter array for operator \"==\" must have 3 elements",
+    "message": "layers[4].filter: Expected two or three arguments." ,
     "line": 47
   },
   {
@@ -55,4 +55,4 @@
     "message": "layers[14].filter[2][1]: string expected, array found",
     "line": 152
   }
-]
+]