-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devDependencies always install #3374
Comments
This was referenced Oct 14, 2016
The shrinkwarp is also causing npm install failures on travis-ci while compiling the
|
lxe
pushed a commit
to lxe/react-map-gl
that referenced
this issue
May 1, 2017
installed. mapbox-gl contained a shrinkwrap with all of its devDependencies listed: mapbox/mapbox-gl-js#3374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mapbox-gl-js version: 0.26.0
Steps to Trigger Behavior
npm install mapbox-gl@0.26.0
Expected Behavior
No dev dependencies should be installed
Actual Behavior
Dev dependencies are installed
The npm-shrinkwrap.json file includes dev dependencies and take president to the package.json. The common practice is for applications to shrinkwrap their dependencies, but libraries typically should not. As a library, shrinkwrapping dependencies can result in larger downstream bundle sizes, as common libraries are less likely to be dedupped.
The text was updated successfully, but these errors were encountered: