Handle NaN as input to a style function or 'interpolate' expression

[lucaswoj]

From @kronick on January 19, 2017 21:38

Right now the binary search I wrote for style function interpolation will go into an infinite loop if passed a NaN as input. I think @lucaswoj fixed this for most use cases by validating stops in the style json before they are passed to interpolated().

But this check is not performed for other uses of this module (as would be desired to get rid of custom color interpolation code in https://www.mapbox.com/mapbox-gl-js/example/data-join/ . See also: #4018). I have hit this problem in my own use of this function, and am now just checking isNaN() myself, but since the failure mode is an infinite loop I feel we should offer a better answer.

What should interpolated() return if passed a NaN? The value of the first stop (as is the default case in categorical functions)? The value of the last stop (as it looks like the old search would have done)? Throw an error? Something else?

I can update the function once I get some advice on what the desired output should be.

Copied from original issue: mapbox/mapbox-gl-style-spec#657

[lucaswoj]

From @jfirebaugh on January 19, 2017 22:18

I think this falls under the same category as #588, and should have the same behavior as whatever we decide there -- probably, return undefined, until there's some means of specifying a fallback result as in #480.

[lucaswoj]

From @kronick on January 20, 2017 1:23

@jfirebaugh Thanks-- I'll stand by until a decision is made there

[jfirebaugh]

@kronick This is unblocked now if you want to pick it up.

[kronick]

@jfirebaugh great! I'll get on it some time this week