Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid glyph requests block rendering #662

Closed
fnicollet opened this issue Aug 7, 2014 · 4 comments
Closed

Invalid glyph requests block rendering #662

fnicollet opened this issue Aug 7, 2014 · 4 comments
Labels
Milestone

Comments

@fnicollet
Copy link
Contributor

Hi,
I was trying an example that someone else on twitter created (@vtcraghead) but didn't get the same result. In my case, I have missing tiles:
https://bl.ocks.org/wboykinm/raw/c43cf9a9fe500276d026/#13.92/34.421322/-119.705140/90.0
What it should render:
https://pbs.twimg.com/media/BucUermCYAAiQeF.png
What I get:
scr-gljs

I am using Chrome 36 on Windows 8.1

If I look at the console, I have a few errors:

Image from origin 'https://www.mapbox.com' has been blocked from loading by Cross-Origin Resource Sharing policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://bl.ocks.org' is therefore not allowed access. 
XMLHttpRequest cannot load https://www.mapbox.com/mapbox-gl-styles/sprites/outdoors.json. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://bl.ocks.org' is therefore not allowed access. 
GET https://mapbox.s3.amazonaws.com/gl-glyphs-256/Open%20Sans%20Normal,%20Arial%20Unicode%20MS%20Bold/0-255.pbf 403 (Forbidden) 

Tell me if you need more informations

@mikemorris
Copy link
Contributor

Looks like the failed glyph protobuf load is blocking rendering.

https://mapbox.s3.amazonaws.com/gl-glyphs-256/Open%20Sans%20Normal,%20Arial%20Unicode%20MS%20Bold/0-255.pbf

is an invalid path (no matching glyph protobuf exists there), although a failed request shouldn't block tile rendering...

@mikemorris
Copy link
Contributor

Ref mapbox/mapbox-gl-native#308 for equivalent issue in mapbox-gl-native

@wboykinm
Copy link

wboykinm commented Aug 7, 2014

Good call - I used the wrong typeface name. Now that it's fixed it's back to rendering smoothly. Though it would indeed be awesome to have it handle the error more elegantly.

@mourner mourner changed the title Missing tiles and forbidden requests Invalid glyph requests block rendering Aug 7, 2014
@mourner mourner added the bug label Aug 7, 2014
@mourner mourner added this to the post-v0.2.0 milestone Aug 7, 2014
ansis added a commit that referenced this issue Aug 8, 2014
@ansis
Copy link
Contributor

ansis commented Aug 8, 2014

thanks for reporting! 7fb6a3d now prevents bad glyph requests from killing the entire tile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants