Fix map.fitBounds() with non-zero bearing #10140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also influences on map.fitScreenCoordinates() and map.cameraForBounds()
|
|
|
Hi @aparshin, Thank you for your contribution. Would you mind telling me why you closed this PR? Your fix would be greatly appreciated. |
|
@stepankuzmin I don't want to contribute to this project after changing TOS in v2.0: #10162 I'm not sure how to delete a PR on Github, so, I just closed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #10064.
In the public API, it fixes behavior of the following methods:
map.fitBounds()map.fitScreenCoordinates()map.cameraForBounds()Changes in tests:
camera => #cameraForBounds(they were incorrect)camera => #fitBoundswith non-zero bearingcamera => #fitScreenCoordinatesto make the input region not squareLaunch Checklist
mapbox-gl-jschangelog:<changelog>Fix a bug where map.fitBounds() behaves incorrectly with non-zero bearing #10064 </changelog>