Color operations, take two #1158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 tasks
|
@lbud what other next actions are there on this? Should this be part of V8? |
|
@tmcw yes, this should be rolled into V8. I dropped the ball on this part because I wasn't sure what was going on with the travis build, but other than that I think this is ready — I'm going to comb through all the color ops changes tonight. I'm in the garage tomorrow through next thurs — let's sync on v8 tomorrow. |
|
Reopening against #1192. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jfirebaugh and I talked about the possibility of refactoring the constant resolution so that it happens within the confines of color-op resolution — its modularity makes that a bit weird but it is a possibility.refs mapbox/mapbox-gl-style-spec#38
and mapbox/mapbox-gl-style-spec#264