Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[needs code review] Add ImageSource for VideoSource-like image sources. #1174

Closed
wants to merge 6 commits into from
Closed

[needs code review] Add ImageSource for VideoSource-like image sources. #1174

wants to merge 6 commits into from

Conversation

tmcw
Copy link
Contributor

@tmcw tmcw commented Apr 20, 2015

2015-04-20 at 3 32 pm

  • Add to mapbox-gl-style-spec

Fixes #700

@mourner
Copy link
Member

mourner commented Apr 20, 2015

There's quite a lot of code duplication between image_source and video_source, in particular in createTile method — needs refactoring (maybe cutting some shared code into utility functions).

@tmcw
Copy link
Contributor Author

tmcw commented Apr 20, 2015

Created a util that de-duplicates the most obviously refactorable chunk of createTile.

@mourner
Copy link
Member

mourner commented Apr 20, 2015

Yeah, that's better.

@tmcw tmcw mentioned this pull request Apr 20, 2015
Merged
82 tasks
@tmcw
Copy link
Contributor Author

tmcw commented Apr 21, 2015

Folded into #1081 V8 PR

@tmcw tmcw closed this Apr 21, 2015
@jfirebaugh jfirebaugh deleted the image-source-two branch May 26, 2015 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for ImageSource, similar to VideoSource
2 participants
@tmcw @mourner