Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert StructArray to ES6 class syntax and simplify #3415

Merged
merged 2 commits into from
Oct 20, 2016
Merged

Convert StructArray to ES6 class syntax and simplify #3415

merged 2 commits into from
Oct 20, 2016

Conversation

mourner
Copy link
Member

@mourner mourner commented Oct 19, 2016 •
edited
Loading

  • Converted to ES6 class syntax.
  • Moved members property downstream from StructType to StructArrayType.
  • Simplified the code overall.

Checklist:

  • post benchmark scores
  • review by @ansis

@mourner
Copy link
Member Author

mourner commented Oct 19, 2016 •
edited
Loading

Relevant benchmarks don't seem to indicate any regressions:

buffer
master 85097c3: 1,023 ms
es6-struct-array 2230579: 1,033 ms

fps
master 85097c3: 60 fps
es6-struct-array 2230579: 60 fps

frame-duration
master 85097c3: 9.7 ms, 15% > 16ms
es6-struct-array 2230579: 9.7 ms, 15% > 16ms

lucaswoj
lucaswoj approved these changes Oct 20, 2016
View reviewed changes
Copy link
Contributor

@lucaswoj lucaswoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @mourner.

@mourner mourner merged commit 7e08170 into master Oct 20, 2016
@mourner mourner deleted the es6-struct-array branch October 20, 2016 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaswoj lucaswoj lucaswoj approved these changes

Assignees
No one assigned
Labels
refactoring 🏗️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mourner @lucaswoj