Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and optimize drawFill #3501

Merged
merged 2 commits into from
Nov 1, 2016
Merged

Simplify and optimize drawFill #3501

merged 2 commits into from
Nov 1, 2016

Conversation

mourner
Copy link
Member

@mourner mourner commented Nov 1, 2016

Cleans up, simplifies and optimizes drawFill. Uses similar technique to #3485, avoiding redundant setUniforms calls between tiles. 👀 @lucaswoj

Mapbox Streets z13 bench:
before: 8.56ms
after: 7.15ms

@mourner mourner added performance ⚡ Speed, stability, CPU usage, memory usage, or power usage refactoring 🏗️ labels Nov 1, 2016
lucaswoj
lucaswoj approved these changes Nov 1, 2016
View reviewed changes
Copy link
Contributor

@lucaswoj lucaswoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I love the negative LOC.

@mourner mourner merged commit 3a9778e into master Nov 1, 2016
@mourner mourner deleted the optimize-draw-fill branch November 1, 2016 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaswoj lucaswoj lucaswoj approved these changes

Assignees
No one assigned
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage refactoring 🏗️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mourner @lucaswoj