Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SymbolBucket#addFeature #3806

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

jfirebaugh
Copy link
Contributor

Shorter and easier to understand.

benchmark master ab83620 refactor-symbol-bucket-add-feature b818121
map-load 131 ms 98 ms
style-load 79 ms 82 ms
buffer 989 ms 988 ms
fps 60 fps 60 fps
frame-duration 4 ms, 0% > 16ms 4.1 ms, 0% > 16ms
query-point 0.87 ms 0.92 ms
query-box 74.26 ms 74.92 ms
geojson-setdata-small 7 ms 5 ms
geojson-setdata-large 223 ms 268 ms

Launch Checklist

  • briefly describe the changes in this PR
  • post benchmark scores
  • manually test the debug page

@jfirebaugh jfirebaugh force-pushed the refactor-symbol-bucket-add-feature branch from b818121 to 12bd220 Compare December 15, 2016 00:29
jfirebaugh added a commit to mapbox/mapbox-gl-native that referenced this pull request Dec 15, 2016
@mollymerp
Copy link
Contributor

yesss love this simplification. do you think the 25% speed up in the map-load bench is really a thing or is it within the normal variability of the bench marks? whoa if true 👏 🎈 ⚡️

@mourner
Copy link
Member

mourner commented Dec 15, 2016

@mollymerp no, this particular benchmark is not useful at this time because it varies too much regardless of the changes. The second run is always smaller.

@jfirebaugh jfirebaugh merged commit a88d192 into master Dec 15, 2016
@jfirebaugh jfirebaugh deleted the refactor-symbol-bucket-add-feature branch December 15, 2016 17:17
jfirebaugh added a commit to mapbox/mapbox-gl-native that referenced this pull request Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants