Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Texture class to dry up code #4811

Closed
wants to merge 1 commit into from
Closed

Conversation

mourner
Copy link
Member

@mourner mourner commented Jun 9, 2017

Abstracts our texture logic (which was repeated in many places) in a Texture class, reducing the amount of code and the error surface. A work in progress — just wanted to get this out to show the direction this is going and get some feedback.

Launch Checklist

  • fix a few render test failures
  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@anandthakker
Copy link
Contributor

@mourner nice! Approach looks good to me overall. One thing I wonder: would it be worthwhile to try to avoid having Texture keep the reference to the GL context, by having it passed in to setData, setImage, etc?

@jfirebaugh
Copy link
Contributor

Added something similar in #5190; tracking future work in #5277.

@jfirebaugh jfirebaugh closed this Sep 12, 2017
@jfirebaugh jfirebaugh deleted the texture-class branch September 12, 2017 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants