guard for offset edgecase in flyTo #5331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
reviewed
Sep 20, 2017
src/ui/camera.js
Outdated
| @@ -785,7 +785,7 @@ class Camera extends Evented { | |||
| let S = (r(1) - r0) / rho; | |||
|
|
|||
| // When u₀ = u₁, the optimal path doesn’t require both ascent and descent. | |||
| if (Math.abs(u1) < 0.000001 || isNaN(S)) { | |||
| if (Math.abs(u1) < 0.000001 || isNaN(S) || S === Infinity) { | |||
There was a problem hiding this comment.
!isFinite(S) could be better here since it also catches -Infinity.
mollymerp
force-pushed
the
flyto-fix
branch
from
d8fcf43
to
a8b91a0
Compare
mourner
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5322
Launch Checklist