Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate flow types from recent style-spec changes #5454

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

lbud
Copy link
Contributor

@lbud lbud commented Oct 12, 2017

As pointed out in #5449 (comment), that PR failed to remove the contextType parameter from the CanvasSourceSpecification flow type. I ran the build script to generate it and it looks like our type definitions are out of date for a few things. @jfirebaugh or @anandthakker — is it weird that flow testing on local machines/CI hasn't complained about these? 🤔

@anandthakker
Copy link
Contributor

is it weird that flow testing on local machines/CI hasn't complained about these?

Good question. I think the reasons there were no complaints is that we're never explicitly calling new CanvasSource(...) except in a unit test (see also #5373) -- so there was no file that flow was checking where we actually omitted the contextType property.

@lbud lbud merged commit 477edc6 into master Oct 13, 2017
@lbud lbud deleted the flow-types-style-spec branch October 13, 2017 19:04
@kkaefer kkaefer added this to the v0.42 milestone Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants