Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mouseover event handler #6000

Merged
merged 6 commits into from
Jan 19, 2018
Merged

added mouseover event handler #6000

merged 6 commits into from
Jan 19, 2018

Conversation

jmandel1027
Copy link
Contributor

@jmandel1027 jmandel1027 commented Jan 16, 2018

Hi there,

I added an event handler for mouseover as requested in #3217. I ran the test suite and everything checks out, fairly new to contributing to open source and would love some feedback!

I've been really enjoying working and learning with mapbox on creative projects like printmaking and custom map vis. Thought it would be a fun learning experience to make some pr's! 🎊

Cheers!
-Jason

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • manually test the debug page
  • post benchmark scores

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Maybe we could cut out the target looking part into a separate function to avoid duplication, but it's probably fine as it is.

@ansis ansis requested review from lucaswoj and removed request for lucaswoj January 16, 2018 18:22
@jmandel1027
Copy link
Contributor Author

Thanks @mourner! 🌱 🎉 Yeaa I was thinking about that as well, I decided to borrow it from mousemove so that it would be specified to the desired dom node on default. I can splice that into a separate function on a future issue/pr request though! 👍

@jmandel1027
Copy link
Contributor Author

Apologies for the noise on this pull request!

I was working on another issue and realized I had merged it to the same branch I was working on.
I went back and reverted that commit to keep things clean on this PR. 😅

@mourner mourner merged commit 35138df into mapbox:master Jan 19, 2018
@mourner
Copy link
Member

mourner commented Jan 19, 2018

No worries! BTW, you can force-push to the branch with the original commit hash instead of reverting.

@jmandel1027
Copy link
Contributor Author

jmandel1027 commented Jan 19, 2018

mmmh good to know! Will deff keep that in mind, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants