Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix web worker error handling #6126

Merged
merged 1 commit into from
Feb 9, 2018
Merged

fix web worker error handling #6126

merged 1 commit into from
Feb 9, 2018

Conversation

mollymerp
Copy link
Contributor

@mollymerp mollymerp commented Feb 9, 2018

changes from #4446 regressed with the new Web Worker transfer, and this was causing hard to diagnose errors like

Error: Error
    at Actor.receive (actor.js:81)

because String(err) was just outputting "Error" with no status code.

Related to #6094

Copy link
Contributor

@lucaswoj lucaswoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! LGTM. :shipit:

@mollymerp mollymerp merged commit b60a83c into master Feb 9, 2018
@mollymerp mollymerp deleted the worker-error branch February 9, 2018 20:58
@jfirebaugh
Copy link
Contributor

@mollymerp Does this fix #5574?

@mollymerp
Copy link
Contributor Author

yes! good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants