Fix touch panning in Edge #6325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-ms- prefix is necessary only for IE10, which is not supported by GL JS.
mollymerp
approved these changes
Mar 14, 2018
There was a problem hiding this comment.
Thanks for tracking this down @jfirebaugh. Are you removing -ms-touch-action because IE 11 supports touch-action?
|
Yep, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touch events are behind a flag in Edge, even on touchscreen devices. 🤷♂️ However, Edge will dispatch mouse events in response to touch input -- in certain circumstances which are not well documented. It seems that it depends on the
touch-actionCSS property being present on particular elements. We previously settouch-action: noneon the.mapboxgl-canvas-containerelement, but this is apparently not enough for Edge. In my tests settingtouch-action: noneon the body element works, as does settingtouch-action: noneon both the canvas container and the canvas. Since we don't want to affect touch-action on the entire page, here's the latter solution.Note that this doesn't fix pinch zooming or touch rotating. Until touch events are unflagged by default, the only way to support those is via pointer events.
Refs #1928.