Split new bounds calculation out of fitBounds into new method #6683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
reviewed
May 22, 2018
mourner
approved these changes
Jun 7, 2018
src/ui/camera.js
Outdated
| * @see [Fit a map to a bounding box](https://www.mapbox.com/mapbox-gl-js/example/fitbounds/) | ||
| */ | ||
| fitBounds(bounds: LngLatBoundsLike, options?: AnimationOptions & CameraOptions, eventData?: Object) { | ||
| const calculatedBounds = this.cameraForBounds(bounds, options); |
There was a problem hiding this comment.
Nit: the variable doesn't represent the bounds, so maybe rename to calculatedOptions or cameraOptions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks transform calculations out of
fitBoundsinto a separate method,getFitBoundsTransform, so that new camera transform calculations can be known without actually moving the map.Launch Checklist