Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mute video source element #6811

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Mute video source element #6811

merged 1 commit into from
Jun 14, 2018

Conversation

jfirebaugh
Copy link
Contributor

Fixes autoplay in Chrome and Safari.

Fixes #6443.

@jfirebaugh
Mute video source element
c1b261e 
Fixes autoplay in Chrome and Safari.
ChrisLoer
ChrisLoer approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I tested that the autoplay worked as expected in mac Chrome and Safari using the "add a video to the map" example.

@jfirebaugh jfirebaugh merged commit d3f8ffc into master Jun 14, 2018
@jfirebaugh jfirebaugh deleted the fix-6443 branch June 14, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLoer ChrisLoer ChrisLoer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfirebaugh @ChrisLoer