allow labels to be placed across tile edges #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`"symbol-avoid-edges": true` can be used to let labels cross tile edges
|
Wow, nice! Where would you want to explicitly disable cross-tile labels — do you need it for symbols that are so big that padded data is not enough to prevent a symbol from colliding differently on adjacent tiles? |
| @@ -6,12 +6,14 @@ var mat4 = require('../lib/glmatrix.js').mat4; | |||
| module.exports = drawSymbols; | |||
|
|
|||
| function drawSymbols(gl, painter, bucket, layerStyle, posMatrix, params, imageSprite) { | |||
| gl.disable(gl.STENCIL_TEST); | |||
There was a problem hiding this comment.
noob question, why we need this here?
|
Reminder: We need to implement this in native before merging ;) |
|
@kkaefer but it's not a breaking change, so could be merged before porting to native... |
|
well, it affects the visual output, so stylesheets will look differently. |
|
+1 for port before merge on these kinds of features |
|
native pull request open at mapbox/mapbox-gl-native#419 |
|
Merged in -native |
mourner
added a commit
that referenced
this pull request
Aug 15, 2014
allow labels to be placed across tile edges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symbol-avoid-edgesto spec addsymbol-avoid-edgesmapbox-gl-style-spec#141Cross tile labels will work the same way they do in mapnik maps. The vectortiles are padded with extra data that gets used to prevent most collisions. symbol-avoid-edges can be used to disable cross-tile labels in the cases this approach does not work well enough.
Labels that exceed tile boundaries may still get clipped during rendering because we're rendering tile-by-tile instead of layer-by-layer labels. #193 will fix this. Native already draws layer-by-layer.