Enable face culling for fill extrusion layers #7252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the winding order of the vertices and enable face culling for the fill extrusion layer so that backward facing triangles are discarded.
anderco
force-pushed
the
anderco-gl-face-culling
branch
from
988ea10
to
d9fa49e
Compare
|
Closing in favour of #7178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7178. See #7178 (comment)
This implements face culling as a new argument to Program::draw so that it can be enabled on layer by layer basis and also enables it for fill extrusion layers. Because of that, only the winding order of that type of layer is changed. If there would be a decision to enforce winding order for other layers that could be done incrementally.