Add variable binding expression example #7317
Conversation
malwoodsantoro
changed the title
There was a problem hiding this comment.
I'm wondering if this is the best example for let and var. The code is almost identical to our choropleth example but with the added overhead of declaring the variable syntax. I agree with the goal of documenting how to use the variables though. @ChrisLoer thoughts?
| @@ -0,0 +1,10 @@ | |||
| /*--- | |||
| title: Visualize population density | |||
| description: Using a [`varible binding expression`](/mapbox-gl-js/style-spec#expressions-variable-binding) to calculate and display population density. | |||
There was a problem hiding this comment.
nit: variable is misspelled here
| ["linear"], | ||
| ["var", "density"], | ||
| 274, | ||
| ["to-color", "#eff3ff"], |
There was a problem hiding this comment.
I think @ChrisLoer 's recent work makes the explicit cast to a color here unnecessary
There was a problem hiding this comment.
I think the cast is necessary until #7301 has merged and is being used by the example page, right?
There was a problem hiding this comment.
LOL, oh yeah. I was working on that. Fridays.
| <script> | ||
| var map = new mapboxgl.Map({ | ||
| container: 'map', // container id | ||
| style: 'mapbox://styles/mapbox/streets-v9', // stylesheet location |
There was a problem hiding this comment.
I have a personal vendetta against streets-v9 in examples. The flattened road labels are 🙅♂️
🤔 Yeah I see your point although it seems like using |
|
I'm ok with it then. Just a couple little nits to clean up. I'll update the example to remove the explicit casts to color when I finish up the test in #7301 |
This example uses
letandvarexpressions to demonstrate variable binding syntax. To test this out locally, you'll need to replace the url to the GeoJSON with the raw data.:)