Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deoptimizations in expression evaluation #7334

Merged
merged 3 commits into from
Sep 26, 2018
Merged

Avoid deoptimizations in expression evaluation #7334

merged 3 commits into from
Sep 26, 2018

Conversation

mourner
Copy link
Member

@mourner mourner commented Sep 26, 2018 •
edited
Loading

A few minor changes that help V8 optimize expression evaluation code better (due to less hidden class changes).

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@mourner
Copy link
Member Author

mourner commented Sep 26, 2018

image
image
image

ChrisLoer
ChrisLoer approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, impressive gains for such a small change!

I'm curious whether the same perf pattern holds in Firefox...

mollymerp
mollymerp approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! also wow your computer is much faster than mine 😬

@mourner
Copy link
Member Author

mourner commented Sep 26, 2018

@ChrisLoer apart from charts display being broken in Firefox, there's a gain there too! 🎉

image

@mourner mourner merged commit c612e07 into master Sep 26, 2018
@mourner mourner deleted the optimize-expressions branch September 26, 2018 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLoer ChrisLoer ChrisLoer approved these changes

@mollymerp mollymerp mollymerp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mourner @ChrisLoer @mollymerp