begin touch zoom immediately when rotation disabled #7582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhamley
approved these changes
Nov 12, 2018
|
Thanks! |
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 15, 2019
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 16, 2019
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
When touch rotation is disabled, there is a lag between when you start pinching to zoom in or out and when the zoom starts happening. This is because the touch zoom rotate handler has a zoom and rotate threshold to disambiguate between the two cases. This threshold is not needed if rotation is disabled. This makes the pinch to zoom behavior comparable with leaflet. There's still a bit of weirdness due do #7196 but it seems to be an improvement.