Optimize setUniforms #7969
Merged
Optimize setUniforms #7969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Surprisingly fails one render test (regressions #5978) — investigating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates unnecessary loops and object lookups in a performance-critical method (
setUniforms). Measuring this with DevTools profiler, the method seems to get 2.5x faster — from taking 9.1% of CPU time to 3.7%.Before:
After:
However, the Paint benchmark doesn't show this improvement — once again implying that it's not representative of real world performance (which needs to be investigated separately).
Launch Checklist
write tests for all new functionalitydocument any changes to public APIs