Set default thumbnail for examples page for development #8025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works well but do you think it might be better to use a true placeholder image kind of like this?
My thinking is that it's easier to quickly find the broken image this way when scanning the examples page. Maybe that's not a huge deal but it could help catch the problem. |
|
@ryanhamley that makes sense. I just pushed a placeholder image with a solid background. At your suggestion, I started playing around with Puppeteer and I think I'll be able to create a script to automatically create the image at the correct dimensions and naming format. I'll create a PR once I have the script cleaned up. |
mourner
approved these changes
Mar 21, 2019
vakila
pushed a commit
that referenced
this pull request
May 30, 2019
* Set default thumbnail for examples page for development (#8025) * Set default thumbnail * Add a little guidance about creating example images * creates placeholder.png * v0.54.0-beta.1 (#8084) * CP removeFeatureState fix (#8090) * Empty out features whose states have been removed instead of removing the feature object. This allows updating the buffers for features whose state has been removed, but also requires keep track of previously removed features. * Update Changelog * v0.54.0 (#8115) * Example for `fill-pattern` (#8022) * move docs dependencies to dev (#8121) (#8129) * Mapbox-gl-geocoder v4 examples (#8053) * add geocoder custom render example * language localize example * Update marker demo to use built-in marker function * remove proximity bias for gl-geocoder example because this is now default behavior * update point from geocode demo to set custom marker color * update examples to use new mapbox-gl-geocoder API options * lint new examples * Update examples to gl-geocoder 4.0.0 api * Options should be added to the geocoder, not the map * lint examples * remove templating syntax * lint fixes * @katydecorah 's code review fixes * Studio does support rtl plugin (#8135) * Update comment for setRTLTextPlugin (#8143) * update comment for setRTLTextPlugin * clarify wording in example * update one more frame after canvas source paused (#8130) (#8163) * update one more frame after canvas source paused Calling `canvasSource.pause()` lets us know we can stop pulling in updates from it. Since it is possible that changes were made to the canvas source since the last render we should pull in one more update before stopping. This also lets you call play and pause immediately to render just one frame: ctx.fillRect(10, 10, 50, 50); canvasSource.play(); canvasSource.pause(); * add test * don't render changes made after canvasSource.pause() * optimize * optimize * Bugfix - removeFeatureState fails with target.id === 0 (#8150) (#8164) * Fix an edge case where 0 target.id would fail to clear the feature state * Check for number & string explicitly * Add tests for 0 feature ID * Fix logical check * v0.54.0-beta.2 (#8166) * [docs] meta updates for search (#8142) * update docs-page-shell, update page-shell; update page meta * Update react-page-shell.js * remove contentType from examples page * Update react-page-shell.js * Update react-page-shell.js * [docs] token refactor in docs-page-shell (#8174) * Update page-shell-script.js * do not force production page shell * remove hardcoded token from example, add unit test to look for access token in example html files * [docs] token refactor in docs-page-shell (#8174) (#8181) * Update page-shell-script.js * do not force production page shell * remove hardcoded token from example, add unit test to look for access token in example html files * Fix disappearing controls in Safari 12+ (#8193) (#8194) * workaround for a Safari 12 bug with disappearing controls * fix css lint * v0.54.0 (take two) (#8184) * v0.54.0 * update changelog once more * fix imagery endpoint on WMS example (#8203) * mapbox-gl-geocoder@v4.2.0 (#8212) * [docs] add trailing slash to `pathname` so resolved URL matches the canonical (#8228) * Update documentation.yml (#8230) * update mapbox-gl-geocoder to v4.3.0 (#8231) * @mapbox/mapbox gl style spec@13.7.0 (#8264) * Prepare @mapbox/mapbox-gl-style-spec@13.7.0 * Add changelog of relevant items * Add sku token to Mapbox API tile requests (#14) (#8276) * v1.0.0 (#8277) * [docs] update docs-page-shell (#8254) * fix pathname * Update react-page-shell.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
When adding a new example, if you didn't set a thumbnail then the examples page would not load due to the failed dependency. This PR sets a default thumbnail image for examples so that the contributor is able to load the examples page locally.