Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP fix removeFeatureState for id = 0 (#8150) #8164

Merged
merged 1 commit into from
Apr 17, 2019
Merged

CP fix removeFeatureState for id = 0 (#8150) #8164

merged 1 commit into from
Apr 17, 2019

Commits on Apr 17, 2019

  1. Bugfix - removeFeatureState fails with target.id === 0 (#8150) 

    * Fix an edge case where 0 target.id would fail to clear the feature state

* Check for number & string explicitly

* Add tests for 0 feature ID

* Fix logical check
    @jutaz @mourner
    jutaz authored and mourner committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    cf09783 View commit details
    Browse the repository at this point in the history