Introduce 'text-writing-mode' layout property that allows to control orientation of point labels #8372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
force-pushed
the
alexshalamov_wip_vertical_labels
branch
from
c0211a3
to
069c6f0
Compare
| "doc": "If a text's language supports horizontal writing mode, symbols with point placement would be laid out horizontally." | ||
| }, | ||
| "vertical": { | ||
| "doc": "If a text's language supports vertical writing mode, symbols with point placement would be laid out vertically." |
There was a problem hiding this comment.
It would be useful to hint what languages are supported with this property.
6 tasks
|
@asheemmamoowala @vakila should I close this PR? I think it is no longer required, all of the changes are in #8399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
For languages that support vertical writing mode, map designers might want point labels to be rendered vertically. This PR adds definition for
text-writing-modelayout property that controls preferred orientation of a symbol. The new property's value is an array, whose values are enumeration values from a( horizontal | vertical )set. PR also adds render tests for newly added property.Native implementation mapbox/mapbox-gl-native#14932
Launch Checklist
@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changes