Add check for startPos to fix #7864 #8462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbarry
commented
Jul 11, 2019
| const canvas = map.getCanvas(); | ||
|
|
||
| const MouseEvent = window(canvas).MouseEvent; | ||
| const event = new MouseEvent('click', {bubbles: true, clientX: 100, clientY: 100}); |
There was a problem hiding this comment.
Alternatively we could expose a simulate.fakeClick utility, but I didn't think we'd want to encourage anyone to re-use that since it only applies to a corner case.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check for
startPosto fix #7864.This falls back to ignoring click tolerance and just firing the click event in the case where startPos is not defined. I've been running with it in production for a few months and have not seen the error since then.